From 54f9593e51455024898b2bb8c583ef884c0d3fd4 Mon Sep 17 00:00:00 2001
From: Stefan Brand <seiichiro@seiichiro0185.org>
Date: Wed, 10 Aug 2022 21:22:40 +0200
Subject: [PATCH] Always use JPEG for Thumbnails

---
 lib/thumbs.class.php | 19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)

diff --git a/lib/thumbs.class.php b/lib/thumbs.class.php
index 9dc8ccb..3d58258 100644
--- a/lib/thumbs.class.php
+++ b/lib/thumbs.class.php
@@ -11,22 +11,15 @@ class thumb {
   const IMAGE_HANDLERS = [
     IMAGETYPE_JPEG => [
         'load' => 'imagecreatefromjpeg',
-        'save' => 'imagejpeg',
-        'quality' => 100
     ],
     IMAGETYPE_PNG => [
         'load' => 'imagecreatefrompng',
-        'save' => 'imagepng',
-        'quality' => 0
     ],
     IMAGETYPE_GIF => [
         'load' => 'imagecreatefromgif',
-        'save' => 'imagegif',
     ],
     IMAGETYPE_WEBP => [
         'load'    => 'imagecreatefromwebp',
-        'save'    => 'imagecreatewebp',
-        'quality' => 90
     ]
   ];
 
@@ -40,10 +33,8 @@ class thumb {
 
   public function get_thumb($iname) {
     $src     = $this->imagedir.$iname;
-    $ext     = pathinfo($iname, PATHINFO_EXTENSION);
     $dstname = hash('sha256', $src);
-    $dstpath = $this->thumbdir.$dstname.'.'.$ext;
-
+    $dstpath = $this->thumbdir.$dstname.'.jpg';
 
     if (!file_exists($dstpath)) {
       $type  = exif_imagetype($src);
@@ -78,15 +69,11 @@ class thumb {
       }
 
       imagecopyresampled($thumbnail, $image, 0, 0, 0, 0, $width, $height, $srcwidth, $srcheight);
-      if ($type != IMAGETYPE_GIF) {
-        call_user_func(self::IMAGE_HANDLERS[$type]['save'],$thumbnail,$dstpath,self::IMAGE_HANDLERS[$type]['quality']);
-      } else {
-        call_user_func(self::IMAGE_HANDLERS[$type]['save'],$thumbnail,$dstpath);
-      }
+      call_user_func('imagejpeg',$thumbnail,$dstpath,100);
       imagedestroy($image);
       imagedestroy($thumbnail);
     }
-    return $this->thumburl.$dstname.'.'.$ext;
+    return $this->thumburl.$dstname.'.jpg';
   }
 }